[COMMON] Replace NodeInfo with Broker #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/org/astraea/app/backup/Backup.java # app/src/main/java/org/astraea/app/web/ReassignmentHandler.java # app/src/main/java/org/astraea/app/web/SkewedPartitionScenario.java # common/src/test/java/org/astraea/common/cost/ReplicaLeaderCostTest.java # common/src/test/java/org/astraea/common/partitioner/StrictCostPartitionerPerfTest.java
請問一下這個方法的用途？如果是從Admin來建立的話應該是可以建立完整的資訊？ |
# Conflicts: # common/src/main/java/org/astraea/common/cost/utils/ClusterInfoSensor.java
目前情境是當 |
# Conflicts: # app/src/test/java/org/astraea/app/web/BalancerHandlerTest.java
|
麻煩修正一下衝突，以及標題名稱修改一下 |
|
標題名稱要加讓 [COMMON] |
chaohengstudent
changed the title
chia7712
reviewed
May 22, 2023
chia7712
reviewed
May 22, 2023
common/src/main/java/org/astraea/common/admin/ConsumerGroup.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
May 22, 2023
# Conflicts: # app/src/main/java/org/astraea/app/web/WebService.java
chia7712
reviewed
May 25, 2023
| @@ -186,12 +186,13 @@ public static byte[] toBytes(BeanObject value) { | |||
| return beanBuilder.build().toByteArray(); | |||
| } | |||
|
|
|||
| // TODO: Due to the change of NodeInfo to Broker. This and the test should be updated. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #1721
主要改動
將
NodeInfo移除，改由Broker物件取代NodeInfo.of(int id, String host, int port)->Broker.of(int id, String host, int port)NodeInfo.of(org.apache.kafka.common.Node node)->Broker.of(org.apache.kafka.common.Node node)修改
Broker相關改動
Admin.nodeInfos()->Admin.brokers()Replica.nodeInfo()->Replica.broker()TODO
若此 pr 可以合併將在 #1721 完成下述：
修改
toBytes(ClusterInfo value)修改
readClusterInfo(byte[] bytes)因序列化格式須修改，測試先暫時移除